]> git.ipfire.org Git - thirdparty/qemu.git/commit
scsi-disk: change disk serial length from 20 to 36
authorRony Weng <ronyweng@synology.com>
Mon, 29 Aug 2016 07:52:18 +0000 (15:52 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 20 Sep 2016 16:03:32 +0000 (11:03 -0500)
commit7aa7c25186fc0cf9d9dd3edf88c8f15deeec3c00
treed50a22b8670de7b8947d23fa40051d64681f2ebf
parentb79239a41bffffbbe4ed412acd191c75ef605cc0
scsi-disk: change disk serial length from 20 to 36

Openstack Cinder assigns volume a 36 characters uuid as serial.
QEMU will shrinks the uuid to 20 characters, which does not match
the original uuid.

Note that there is no limit to the length of the serial number in
the SCSI spec.  20 was copy-pasted from virtio-blk which in turn was
copy-pasted from ATA; 36 is even more arbitrary.  However, bumping it
up too much might cause issues (e.g. 252 seems to make sense because
then the maximum amount of returned data is 256; but who knows there's
no off-by-one somewhere for such a nicely rounded number).

Signed-off-by: Rony Weng <ronyweng@synology.com>
Message-Id: <1472457138-23386-1-git-send-email-ronyweng@synology.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 48b6206305b8d56524ac2ee347b68e6e0a528559)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/scsi/scsi-disk.c