]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
power: supply: core: fix static checker warning
authorSebastian Reichel <sebastian.reichel@collabora.com>
Sun, 6 Jul 2025 23:26:58 +0000 (01:26 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Sat, 12 Jul 2025 18:45:17 +0000 (20:45 +0200)
commit7b41a2341fa62babda5d5c7a32c632e9eba2ee11
tree52f957742f60e068b2921c3cfa19dc49c96e57c2
parentf9335bb4f5d4f3b913efd5872c2794d027dd85a6
power: supply: core: fix static checker warning

static checker complains, that the block already breaks if IS_ERR(np)
and thus the extra !IS_ERR(np) check in the while condition is
superfluous. Avoid the extra check by using while(true) instead. This
should not change the runtime behavior at all and I expect the binary
to be more or less the same for an optimizing compiler.

Fixes: f368f87b22da ("power: supply: core: convert to fwnnode")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-pm/285c9c39-482c-480c-8b0b-07111e39fdfe@sabinyo.mountain/
Reviewed-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/r/20250707-fix-psy-static-checker-warning-v1-1-42d555c2b68a@collabora.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/power_supply_core.c