]> git.ipfire.org Git - thirdparty/libvirt.git/commit
projects / thirdparty / libvirt.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b7f7f07) | patch
util: don't validate empty params
authorOleg Vasilev <oleg.vasilev@virtuozzo.com>
Fri, 23 Jun 2023 09:20:50 +0000 (15:20 +0600)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 26 Jun 2023 12:19:18 +0000 (14:19 +0200)
commit7b793a00bddd34c56393e1dbaa7dc85700059c55
tree1a99c5686d5bade0f7603d0dfc7ec187308635d8tree | snapshot
parentb7f7f07542fd2569fec2ae925330eea1e2989d40commit | diff
util: don't validate empty params

If there are no parameters, there is nothing to validate.
If params == NULL, memcpy below results in memcpy(sorted, NULL, 0),
which is UB.

Found by UBSAN. Example of this codepath: virDomainBlockCopy()
(where nparams == 0 is valid) -> qemuDomainBlockCopy()

Signed-off-by: Oleg Vasilev <oleg.vasilev@virtuozzo.com>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
src/util/virtypedparam.c diff | blob | blame | history
Mirror of https://github.com/libvirt/libvirt.git