]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dm verity: initialize fec io before freeing it
authorWu Bo <bo.wu@vivo.com>
Wed, 22 Nov 2023 03:51:49 +0000 (20:51 -0700)
committerMike Snitzer <snitzer@kernel.org>
Wed, 29 Nov 2023 17:23:17 +0000 (12:23 -0500)
commit7be05bdfb4efc1396f7692562c7161e2b9f595f1
tree3bbfe0f398cda288df00eb036b694d1b9055c7d2
parent2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
dm verity: initialize fec io before freeing it

If BIO error, verity_end_io() can call verity_finish_io() before
verity_fec_init_io(). Therefore, fec_io->rs is not initialized and
may crash when doing memory freeing in verity_fec_finish_io().

Crash call stack:
 die+0x90/0x2b8
 __do_kernel_fault+0x260/0x298
 do_bad_area+0x2c/0xdc
 do_translation_fault+0x3c/0x54
 do_mem_abort+0x54/0x118
 el1_abort+0x38/0x5c
 el1h_64_sync_handler+0x50/0x90
 el1h_64_sync+0x64/0x6c
 free_rs+0x18/0xac
 fec_rs_free+0x10/0x24
 mempool_free+0x58/0x148
 verity_fec_finish_io+0x4c/0xb0
 verity_end_io+0xb8/0x150

Cc: stable@vger.kernel.org # v6.0+
Fixes: 5721d4e5a9cd ("dm verity: Add optional "try_verify_in_tasklet" feature")
Signed-off-by: Wu Bo <bo.wu@vivo.com>
Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-verity-target.c