]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/block/nvme: support the get/set features select and save fields
authorKlaus Jensen <k.jensen@samsung.com>
Mon, 6 Jul 2020 06:12:57 +0000 (08:12 +0200)
committerKlaus Jensen <k.jensen@samsung.com>
Wed, 2 Sep 2020 06:48:50 +0000 (08:48 +0200)
commit7c46310d298d8caa9dd0e4c0846331dd148a575c
tree37f4f0c7b58c7e7815a83ccf69791ddf4027e0c8
parent1302e48e499c526583b3182ad8c9b7e32010ac53
hw/block/nvme: support the get/set features select and save fields

Since the device does not have any persistent state storage, no
features are "saveable" and setting the Save (SV) field in any Set
Features command will result in a Feature Identifier Not Saveable status
code.

Similarly, if the Select (SEL) field is set to request saved values, the
devices will (as it should) return the default values instead.

Since this also introduces "Supported Capabilities", the nsid field is
now also checked for validity wrt. the feature being get/set'ed.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Message-Id: <20200706061303.246057-13-its@irrelevant.dk>
hw/block/nvme.c
hw/block/trace-events
include/block/nvme.h