]> git.ipfire.org Git - thirdparty/libvirt.git/commit
wireshark: Install to generic plugin directory
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 27 Oct 2015 13:02:19 +0000 (14:02 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 29 Oct 2015 12:55:06 +0000 (13:55 +0100)
commit7c8250d76561e83adf96b8e167f6932132252744
treecc17ff740afed6acab417a22a3f53970f9bdf9b2
parent2589ca30196b305956f4211bc08132b63f77b6f2
wireshark: Install to generic plugin directory

There has been a report on the list [1] that we are not
installing the wireshark dissector into the correct plugin
directory. And in fact we are not. The problem is, the plugin
directory path is constructed at compile time. However, it's
dependent on the wireshark version, e.g.

  /usr/lib/wireshark/plugins/1.12.6

This is rather unfortunate, because if libvirt RPMs were built
with one version, but installed on a system with newer one, the
plugins are not really loaded. This problem lead fedora packagers
to unify plugin path to:

  /usr/lib/wireshark/plugins/

Cool! But this was enabled just in wireshark-1.12.6-4. Therefore,
we must require at least that version.

And while at it, on some distributions, the wireshark.pc file
already has a variable that defines where plugin dir is. Use that
if possible.

1: https://www.redhat.com/archives/libvirt-users/2015-October/msg00063.html

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
libvirt.spec.in
m4/virt-wireshark.m4