]> git.ipfire.org Git - thirdparty/libvirt.git/commit
libxl: Fix initialization of nictype in libxl_device_nic
authorJim Fehlig <jfehlig@suse.com>
Mon, 6 Jan 2014 18:37:20 +0000 (11:37 -0700)
committerJim Fehlig <jfehlig@suse.com>
Mon, 6 Jan 2014 23:15:32 +0000 (16:15 -0700)
commit7c98d1c153da5810ed4dcaa6be177df369b7d4bd
treed68854662139990668a2a85ebeab77f04c6d9f0b
parentf3e359d66529aada961118c1fce9e963c274e9e1
libxl: Fix initialization of nictype in libxl_device_nic

As pointed out by the Xen folks [1], HVM nics should always be set
to type LIBXL_NIC_TYPE_VIF_IOEMU unless the user explicity requests
LIBXL_NIC_TYPE_VIF via model='netfront'.  The current logic in
libxlMakeNic() only sets the nictype to LIBXL_NIC_TYPE_VIF_IOEMU if
a model is specified that is not 'netfront', which breaks PXE booting
configurations where no model is specified (i.e. use the hypervisor
default).

Reported-by: Stefan Bader <stefan.bader@canonical.com>
[1] https://www.redhat.com/archives/libvir-list/2013-December/msg01156.html
src/libxl/libxl_conf.c
src/libxl/libxl_conf.h