]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix OpenSSL private key passphrase notices
authorSanttu Lakkala <santtu.lakkala@jolla.com>
Mon, 21 Oct 2019 11:35:06 +0000 (14:35 +0300)
committerGert Doering <gert@greenie.muc.de>
Tue, 24 Mar 2020 17:38:24 +0000 (18:38 +0100)
commit7d19b2bb7b4a4976bc720d72227ee79c440e06fc
tree2739e712641f6dfbb5f14a24de82da137ea782b1
parent8484f37a62ce4f1b8efe7644c6ddb28819c4f8ae
Fix OpenSSL private key passphrase notices

Clear error stack on successful certificate loading in
tls_ctx_load_cert_file_and_copy() and handle errors also for
PEM_read_bio_PrivateKey() call in tls_ctx_load_priv_file().

Due to certificate loading possibly leaking non-fatal errors on OpenSSL
error stack, and some slight oversights in error handling, the

>PASSWORD:Verification Failed: 'Private Key'

line was never produced on the management channel for PEM formatted keys.

Signed-off-by: Santtu Lakkala <santtu.lakkala@jolla.com>
Acked-by: Steffan Karger <steffan.karger@fox-it.com>
Message-Id: <20191021113506.30377-1-santtu.lakkala@jolla.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18953.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit f67efa9412a62f477aa17c3179b7e9f31ac4b25f)
src/openvpn/ssl_openssl.c