]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Mon, 20 Jan 2020 16:01:17 +0000 (18:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:38:38 +0000 (08:38 +0100)
commit7dabba5b77f461071cc6ddf7187a575f29a64195
tree33e52dab1c98a9ff3570a9d9a2b4caf9a28cea59
parent93d1648ab3110ea460efbb0595ffc3b2ad383690
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()

[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: https://github.com/thesofproject/linux/issues/1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/hda/patch_hdmi.c