]> git.ipfire.org Git - thirdparty/shadow.git/commit
Quick fix: define E_PAM_ERR in lib/pam_pass.c
authorSerge Hallyn <serge@hallyn.com>
Wed, 26 Mar 2025 13:23:52 +0000 (08:23 -0500)
committerSerge Hallyn <serge@hallyn.com>
Wed, 26 Mar 2025 13:45:17 +0000 (08:45 -0500)
commit7e605222df006458a2edfbbe3875db858eff115e
treee92a89bafb45add3e55680fb0b50b9c5401ad27b
parenta68c2ae3db5171524ba587bbc78acc8d8f8b7dd8
Quick fix: define E_PAM_ERR in lib/pam_pass.c

The exit code situation is a hot mess. Do a
  git grep "define.*E_SUCCESS"
Each src/*.c is defining its own set of error codes, and
they are frequently conflicting, e.g. more than one use
10.

We should probably have a common set defined in lib/exitcodes.h.
I'm thinking for a first cut, we just move all the definitions
from src/*.c to lib/exitcodes.h, and let the conflicts stand.
If we later want to change some defines to make them unambiguous
across the project, we can do that separately.

Signed-off-by: Serge Hallyn <serge@hallyn.com>
lib/pam_pass.c