]> git.ipfire.org Git - thirdparty/linux.git/commit
KEYS: fix key refcount leak in keyctl_read_key()
authorEric Biggers <ebiggers@google.com>
Mon, 18 Sep 2017 18:36:31 +0000 (11:36 -0700)
committerDavid Howells <dhowells@redhat.com>
Mon, 25 Sep 2017 14:19:57 +0000 (15:19 +0100)
commit7fc0786d956d9e59b68d282be9b156179846ea3d
tree0b652a2ec8836a6d101e48a0ba1e07472f636432
parent884bee0215fcc239b30c062c37ca29077005e064
KEYS: fix key refcount leak in keyctl_read_key()

In keyctl_read_key(), if key_permission() were to return an error code
other than EACCES, we would leak a the reference to the key.  This can't
actually happen currently because key_permission() can only return an
error code other than EACCES if security_key_permission() does, only
SELinux and Smack implement that hook, and neither can return an error
code other than EACCES.  But it should still be fixed, as it is a bug
waiting to happen.

Fixes: 29db91906340 ("[PATCH] Keys: Add LSM hooks for key management [try #3]")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
security/keys/keyctl.c