]> git.ipfire.org Git - thirdparty/linux.git/commit
apparmor: Fix move_mount mediation by detecting if source is detached
authorJohn Johansen <john.johansen@canonical.com>
Mon, 18 Dec 2023 09:10:03 +0000 (01:10 -0800)
committerJohn Johansen <john.johansen@canonical.com>
Wed, 3 Jan 2024 20:10:29 +0000 (12:10 -0800)
commit8026e40608b4d552216d2a818ca7080a4264bb44
tree1fdeea61a54b06d41723a44cc4a0f3229a9db9cc
parent610a9b8f49fbcf1100716370d3b5f6f884a2835a
apparmor: Fix move_mount mediation by detecting if source is detached

Prevent move_mount from applying the attach_disconnected flag
to move_mount(). This prevents detached mounts from appearing
as / when applying mount mediation, which is not only incorrect
but could result in bad policy being generated.

Basic mount rules like
  allow mount,
  allow mount options=(move) -> /target/,

will allow detached mounts, allowing older policy to continue
to function. New policy gains the ability to specify `detached` as
a source option
  allow mount detached -> /target/,

In addition make sure support of move_mount is advertised as
a feature to userspace so that applications that generate policy
can respond to the addition.

Note: this fixes mediation of move_mount when a detached mount is used,
      it does not fix the broader regression of apparmor mediation of
      mounts under the new mount api.

Link: https://lore.kernel.org/all/68c166b8-5b4d-4612-8042-1dee3334385b@leemhuis.info/T/#mb35fdde37f999f08f0b02d58dc1bf4e6b65b8da2
Fixes: 157a3537d6bc ("apparmor: Fix regression in mount mediation")
Reviewed-by: Georgia Garcia <georgia.garcia@canonical.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
security/apparmor/apparmorfs.c
security/apparmor/mount.c