]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Mon, 15 Jul 2019 13:17:03 +0000 (14:17 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 1 Oct 2019 21:58:28 +0000 (16:58 -0500)
commit804a0ae6c07bae1de5620b553866d08db8a8acf0
tree6d7a975f0b9453f6788616333a464038228ce5bf
parent255325da13fb93fb417adec98c614229bd6e6acc
hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory

Lei Sun found while auditing the code that a CPU write would
trigger a NULL pointer dereference.

>From UG1085 datasheet [*] AXI writes in this region are ignored
and generates an AXI Slave Error (SLVERR).

Fix by implementing the write_with_attrs() handler.
Return MEMTX_ERROR when the region is accessed (this error maps
to an AXI slave error).

[*] https://www.xilinx.com/support/documentation/user_guides/ug1085-zynq-ultrascale-trm.pdf

Reported-by: Lei Sun <slei.casper@gmail.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Tested-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit 936a236c4e4b1068ade99220260cd04f68eb0212)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/ssi/xilinx_spips.c