]> git.ipfire.org Git - thirdparty/qemu.git/commit
vdpa net: zero vhost_vdpa iova_tree pointer at cleanup
authorEugenio Pérez <eperezma@redhat.com>
Wed, 13 Sep 2023 12:34:08 +0000 (14:34 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 6 Oct 2023 12:32:41 +0000 (15:32 +0300)
commit809d5995c8b9560fbf2c2bea69123d767c8caca5
tree35a8b780cfa4fa9960cedc5c6f41c1230b8d355d
parent2990ba54715fc802fc28eb67930d6b7c3b90af3c
vdpa net: zero vhost_vdpa iova_tree pointer at cleanup

Not zeroing it causes a SIGSEGV if the live migration is cancelled, at
net device restart.

This is caused because CVQ tries to reuse the iova_tree that is present
in the first vhost_vdpa device at the end of vhost_vdpa_net_cvq_start.
As a consequence, it tries to access an iova_tree that has been already
free.

Fixes: 00ef422e9fbf ("vdpa net: move iova tree creation from init to start")
Reported-by: Yanhui Ma <yama@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Message-Id: <20230913123408.2819185-1-eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>
Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 0a7a164bc37b4ecbf74466e1e5243d72a768ad06)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
net/vhost-vdpa.c