]> git.ipfire.org Git - thirdparty/gcc.git/commit
d: Fix core.volatile.volatileLoad discarded if result is unused
authorIain Buclaw <ibuclaw@gdcproject.org>
Sun, 2 Jul 2023 01:24:53 +0000 (03:24 +0200)
committerIain Buclaw <ibuclaw@gdcproject.org>
Sun, 2 Jul 2023 01:37:05 +0000 (03:37 +0200)
commit80ae426a195a0d035640a6301da833564deade52
tree0aa16cb1bc0df8e8c80db61da2aa46373ff2b0d4
parent67e0967b32af60cdf5a0c3e811bfa63c30dcdb76
d: Fix core.volatile.volatileLoad discarded if result is unused

The first pass of code generation in the D front-end splits up all
compound expressions and discards expressions that have no side effects.
This included calls to the `volatileLoad' intrinsic if its result was
not used, causing such calls to be eliminated from the program.

We already set TREE_THIS_VOLATILE on the expression, however the
tree documentation says if this bit is set in an expression, so is
TREE_SIDE_EFFECTS.  So set TREE_SIDE_EFFECTS on the expression too.
This prevents any early discarding from occuring.

PR d/110516

gcc/d/ChangeLog:

* intrinsics.cc (expand_volatile_load): Set TREE_SIDE_EFFECTS on the
expanded expression.
(expand_volatile_store): Likewise.

gcc/testsuite/ChangeLog:

* gdc.dg/torture/pr110516a.d: New test.
* gdc.dg/torture/pr110516b.d: New test.
gcc/d/intrinsics.cc
gcc/testsuite/gdc.dg/torture/pr110516a.d [new file with mode: 0644]
gcc/testsuite/gdc.dg/torture/pr110516b.d [new file with mode: 0644]