]> git.ipfire.org Git - thirdparty/qemu.git/commit
Revert "virtio: don't call device on !vm_running"
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 11 Sep 2014 15:42:02 +0000 (18:42 +0300)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 23 Sep 2014 15:48:06 +0000 (10:48 -0500)
commit80f4d021f0323934df90f8c7f0954703d088c200
tree2ed350e028da321682ae7b799868a0446c94bada
parent074e3471386ec97ffa145642ba614b2b87be2f10
Revert "virtio: don't call device on !vm_running"

This reverts commit a1bc7b827e422e1ff065640d8ec5347c4aadfcd8.
    virtio: don't call device on !vm_running
It turns out that virtio net assumes that vm_running
is updated before device status callback in many places,
so this change leads to asserts.
Previous commit fixes the root issue that motivated
a1bc7b827e422e1ff065640d8ec5347c4aadfcd8 differently,
so there's no longer a need for this change.

In the future, we might be able to drop checking vm_running
completely, and check vm state directly.

Reported-by: Dietmar Maurer <dietmar@proxmox.com>
Cc: qemu-stable@nongnu.org
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 9e8e8c48653471fa5fed447e388fdef57d4f6998)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/virtio/virtio.c