]> git.ipfire.org Git - thirdparty/qemu.git/commit
vhost: correctly pass error to caller in vhost_dev_enable_notifiers()
authorJason Wang <jasowang@redhat.com>
Fri, 29 May 2015 06:13:14 +0000 (14:13 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 29 Jul 2015 23:44:36 +0000 (18:44 -0500)
commit81cb0a565795de57672f761f04e29e08dfde067c
tree2f4728ff88e294f2ba9128f4c4f4cc9d26355aa2
parent6130c462328d89910be6dbea4bdc35baa7107104
vhost: correctly pass error to caller in vhost_dev_enable_notifiers()

We override the error value r in fail_vq, this will cause the caller
can't detect the failure which may cause the caller may disable the
notifiers twice if vhost is failed to start. Fix this by using another
variable to keep track the return value of set_host_notifier().

Fixes b0b3db79559e57db340b292621c397e7a6cdbdc5 ("vhost-net: cleanup
host notifiers at last step")

Cc: qemu-stable@nongnu.org
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 16617e36b02ebdc83f215d89db9ac00f7d6d6d83)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/virtio/vhost.c