]> git.ipfire.org Git - thirdparty/samba.git/commit
lib:param: Add missing return code check
authorAndreas Schneider <asn@samba.org>
Mon, 8 Jul 2024 10:26:47 +0000 (12:26 +0200)
committerGünther Deschner <gd@samba.org>
Tue, 16 Jul 2024 11:41:33 +0000 (11:41 +0000)
commit8268b3efff9b0c8475df6a51451f0b4a399718b1
treeb08763aeb7665598c9a5d7bf8b5495198deb196d
parentc3abd320e67f77d016d2e02da084c34615d1c7f9
lib:param: Add missing return code check

"Error: NEGATIVE_RETURNS (CWE-394):
samba-4.20.0rc2/lib/param/loadparm.c:1275: negative_return_fn: Function ""lpcfg_map_parameter(""printing"")"" returns a negative number.
samba-4.20.0rc2/lib/param/loadparm.c:1275: assign: Assigning: ""parm_num"" = ""lpcfg_map_parameter(""printing"")"".
samba-4.20.0rc2/lib/param/loadparm.c:1278: negative_returns: Using variable ""parm_num"" as an index to array ""parm_table"".
 1276|    }
 1277|
 1278|->  if (!lp_set_enum_parm(&parm_table[parm_num], pszParmValue, (int*)ptr)) {
 1279|    return false;
 1280|    }"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
lib/param/loadparm.c