]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commit
feat: ignore `gutter-output` for margin grid in `xy-cell` mixins
authorDaniel Ruf <daniel@daniel-ruf.de>
Sun, 29 Apr 2018 21:26:14 +0000 (23:26 +0200)
committerDaniel Ruf <daniel.ruf@ueberbit.de>
Mon, 30 Apr 2018 08:04:32 +0000 (10:04 +0200)
commit828481aa8eb67258a53c3a68ba41221388ce0045
treea947bf91bc441958182a62dd1fef7cc7fc0e9fdd
parenta715af00801e43ae2736a32bf7d3b955079c93dc
feat: ignore `gutter-output` for margin grid in `xy-cell` mixins

`gutter-output` cannot be set to `false` for margin grid as the gutter (margin)
is defined with the width. Gutters can only be set or reset to 0, which does
not fullful the role of `gutter-output`.

See discussion at https://github.com/zurb/foundation-sites/pull/11081

**BREAKING CHANGE**

Before:
```scss
@include xy-cell(12, $gutter-type: margin, $gutter-output: false);
@include xy-cell-static(full, $gutter-type: margin, $gutter-output: false);
```

After
```scss
@include xy-cell(12, $gutter-type: margin, $gutters: 0);
@include xy-cell-static(full, $gutter-type: margin, $gutters: 0);
```

Co-authored-by: Nicolas Coden <nicolas@ncoden.fr>
Co-authored-by: SassNinja <kai.falkowski@gmail.com>
scss/xy-grid/_cell.scss