]> git.ipfire.org Git - people/arne_f/kernel.git/commit
drivers: char: mem: Check for address space wraparound with mmap()
authorJulius Werner <jwerner@chromium.org>
Fri, 12 May 2017 21:42:58 +0000 (14:42 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 May 2017 12:30:18 +0000 (14:30 +0200)
commit837bfdb41337fc6b82dbde4b2ec3ce923845049f
tree88efa00280687d6da5bb13f0d19e5e0cf54c8208
parent52cf24769487de7100d824e8c12ecc310de841d7
drivers: char: mem: Check for address space wraparound with mmap()

commit b299cde245b0b76c977f4291162cf668e087b408 upstream.

/dev/mem currently allows mmap() mappings that wrap around the end of
the physical address space, which should probably be illegal. It
circumvents the existing STRICT_DEVMEM permission check because the loop
immediately terminates (as the start address is already higher than the
end address). On the x86_64 architecture it will then cause a panic
(from the BUG(start >= end) in arch/x86/mm/pat.c:reserve_memtype()).

This patch adds an explicit check to make sure offset + size will not
wrap around in the physical address type.

Signed-off-by: Julius Werner <jwerner@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/mem.c