]> git.ipfire.org Git - thirdparty/qemu.git/commit
tests/qtest: fix registration of ABRT handler for QEMU cleanup
authorDaniel P. Berrangé <berrange@redhat.com>
Fri, 13 May 2022 15:49:05 +0000 (16:49 +0100)
committerThomas Huth <thuth@redhat.com>
Wed, 18 May 2022 06:54:22 +0000 (08:54 +0200)
commit83f79d4efc8dac7e511bc4375d0f9d90ff9db731
tree1cbb76990d8570a48df6d14e106432f78dc7262c
parentf3f0cbaf97c78b1fc1f3855f576e46ea6ad4f34c
tests/qtest: fix registration of ABRT handler for QEMU cleanup

qtest_init registers a hook to cleanup the running QEMU process
should g_assert() fire before qtest_quit is called. When the first
hook is registered, it is supposed to triggere registration of the
SIGABRT handler. Unfortunately the logic in hook_list_is_empty is
inverted, so the SIGABRT handler never gets registered, unless
2 or more QEMU processes are run concurrently. This caused qtest
to leak QEMU processes anytime g_assert triggers.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220513154906.206715-2-berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/qtest/libqtest.c