]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: aloop: Release cable upon open error path
authorTakashi Iwai <tiwai@suse.de>
Fri, 5 Jan 2018 15:09:47 +0000 (16:09 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 3 Mar 2018 15:52:14 +0000 (15:52 +0000)
commit8418d2262143ce2f1e7171c3fb1e0896a7a9d009
treec4ca1a25d6fea5392213cf225f72c0a70365b994
parente6bc4d220161b2b7268465e94fbe3bc57b009ab2
ALSA: aloop: Release cable upon open error path

commit 9685347aa0a5c2869058ca6ab79fd8e93084a67f upstream.

The aloop runtime object and its assignment in the cable are left even
when opening a substream fails.  This doesn't mean any memory leak,
but it still keeps the invalid pointer that may be referred by the
another side of the cable spontaneously, which is a potential Oops
cause.

Clean up the cable assignment and the empty cable upon the error path
properly.

Fixes: 597603d615d2 ("ALSA: introduce the snd-aloop module for the PCM loopback")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/drivers/aloop.c