]> git.ipfire.org Git - thirdparty/qemu.git/commit
vga: fix region calculation
authorGerd Hoffmann <kraxel@redhat.com>
Fri, 9 Mar 2018 14:37:04 +0000 (15:37 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 21 Jun 2018 01:45:07 +0000 (20:45 -0500)
commit84cfae0b6f232c8ac8aaa37ead01ed49c5d32dfd
tree31027581e090bf9dbcd7e7637f909f1729f4d503
parentd80b60fc2433cc934533f594bfa4e2b6c6103ba3
vga: fix region calculation

Typically the scanline length and the line offset are identical.  But
in case they are not our calculation for region_end is incorrect.  Using
line_offset is fine for all scanlines, except the last one where we have
to use the actual scanline length.

Fixes: CVE-2018-7550
Reported-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Prasad J Pandit <pjp@fedoraproject.org>
Tested-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Message-id: 20180309143704.13420-1-kraxel@redhat.com
(cherry picked from commit 7cdc61becd095b64a786b2625f321624e7111f3d)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/display/vga.c