]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virt-host-validate: Call VIR_HOST_VALIDATE_FAILURE() more frequently
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 8 Jun 2021 07:20:32 +0000 (09:20 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 9 Jun 2021 06:23:18 +0000 (08:23 +0200)
commit853228c0228dd0c4b06acded964f1a2ad9d3add1
tree5fc269c920812d73773ef853d24c2a46d0e83ade
parent7ea5a80dc143cd218e83e9976c7cbe77c84e384b
virt-host-validate: Call VIR_HOST_VALIDATE_FAILURE() more frequently

Ideally, every virHostMsgFail() would be coupled with
VIR_HOST_VALIDATE_FAILURE() so that the failure is correctly
propagated to the caller. However, in
virHostValidateSecureGuests() we are either ignoring @level and
returning 0 directly (no error), or not returning at all, relying
on 'return 0' at the end of the function. Neither of these help
propagate failure correctly.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Fabiano Fidêncio <fabiano@fidencio.org>
tools/virt-host-validate-common.c