]> git.ipfire.org Git - thirdparty/qemu.git/commit
block/iscsi: fix double-free on BUSY or similar statuses
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 10 Jan 2023 16:36:33 +0000 (17:36 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 29 Mar 2023 07:20:04 +0000 (10:20 +0300)
commit856a67cadea901221c69fb4251c038389a5d4571
tree19e941609f013a29fe2d0d352bc3f555a0e80bd1
parentf163cf6be4b7b51f7327d264ea2572f8b495d287
block/iscsi: fix double-free on BUSY or similar statuses

Commit 8c460269aa77 ("iscsi: base all handling of check condition on
scsi_sense_to_errno", 2019-07-15) removed a "goto out" so that the
same coroutine is re-entered twice; once from iscsi_co_generic_cb,
once from the timer callback iscsi_retry_timer_expired.  This can
cause a crash.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1378
Reported-by: Grzegorz Zdanowski <https://gitlab.com/kiler129>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 5080152e2ef6cde7aa692e29880c62bd54acb750)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
block/iscsi.c