]> git.ipfire.org Git - thirdparty/samba.git/commit
s4:torture: Do not set sr.in.info to info be we queried the info
authorAndreas Schneider <asn@samba.org>
Mon, 8 Jul 2024 09:39:28 +0000 (11:39 +0200)
committerGünther Deschner <gd@samba.org>
Tue, 16 Jul 2024 12:42:39 +0000 (12:42 +0000)
commit85d80240ec73d5fddd2e254ee142d06fe096f133
tree7cd90702ea622b6f2704299f5b8786619cc5a1c4
parent8268b3efff9b0c8475df6a51451f0b4a399718b1
s4:torture: Do not set sr.in.info to info be we queried the info

`sr.in.info = info` is correctly set later after we called
dcerpc_lsa_QueryTrustedDomainInfoByName_r() which filling the info
pointer with data.

"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source4/torture/rpc/forest_trust.c:211: var_decl: Declaring variable ""info"" without initializer.
samba-4.20.0rc2/source4/torture/rpc/forest_trust.c:248: uninit_use: Using uninitialized value ""info"".
  246|    sr.in.trusted_domain = talloc_zero(tctx, struct lsa_String);
  247|    sr.in.trusted_domain->string = name;
  248|->  sr.in.info = info;
  249|
  250|    for (c = 0; il[c].info_level != -1; c++) {"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Jul 16 12:42:39 UTC 2024 on atb-devel-224
source4/torture/rpc/forest_trust.c