]> git.ipfire.org Git - thirdparty/glibc.git/commit
Avoid fall-through in test-container if execlp fails.
authorJoseph Myers <joseph@codesourcery.com>
Wed, 13 Feb 2019 13:34:24 +0000 (13:34 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Wed, 13 Feb 2019 13:34:24 +0000 (13:34 +0000)
commit86140c6223b5d14d773cf3050ffd0d14977c2c2d
tree4a046647a5946527009fdc5b0812c1b70fe176a4
parent16f87cfd630522afe745a0cf665287b8fe206cf4
Avoid fall-through in test-container if execlp fails.

One of the implicit-fallthrough warnings from compiling glibc with
-Wextra appears to indicate an actual bug: the test-container code
could fall through inappropriately if execlp returns (which only
occurs on error).  This patch adds appropriate error handling in this
case to avoid that fall-through.

Tested for x86_64.

* support/test-container.c (recursive_remove): Use FAIL_EXIT1 if
execlp returns.
ChangeLog
support/test-container.c