]> git.ipfire.org Git - thirdparty/qemu.git/commit
pr-helper: fix assertion failure on failed multipath PERSISTENT RESERVE IN
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 20 Jun 2018 17:36:15 +0000 (19:36 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 28 Jun 2018 17:05:35 +0000 (19:05 +0200)
commit86933b4e7879e427e03365bf352c0964640cb37b
tree83d44b80179357c1b55f29d76bff9fb79a52e47b
parent50fa332516d5e42695811f43396b749185e21b9c
pr-helper: fix assertion failure on failed multipath PERSISTENT RESERVE IN

The response size is expected to be zero if the SCSI status is not
"GOOD", but nothing was resetting it.

This can be reproduced simply by "sg_persist -s /dev/sdb" where /dev/sdb
in the guest is a scsi-block device corresponding to a multipath device
on the host.

Before:

  PR in (Read full status): Aborted command

and on the host:

  prh_write_response: Assertion `resp->sz == 0' failed.

After:

  PR in (Read full status): bad field in cdb or parameter list
  (perhaps unsupported service action)

Reported-by: Jiri Belka <jbelka@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
scsi/qemu-pr-helper.c