]> git.ipfire.org Git - thirdparty/qemu.git/commit
mirror: Minor refactoring
authorEric Blake <eblake@redhat.com>
Fri, 9 May 2025 20:40:23 +0000 (15:40 -0500)
committerEric Blake <eblake@redhat.com>
Wed, 14 May 2025 21:52:40 +0000 (16:52 -0500)
commit870f8963cf1a84f8ec929b05a6d68906974a76c5
tree73120e5ff3916c72ee5eb62e3bc08dafbd0d7656
parenteb89627899bb84148d272394e885725eff456ae9
mirror: Minor refactoring

Commit 5791ba52 (v9.2) pre-initialized ret in mirror_dirty_init to
silence a false positive compiler warning, even though in all code
paths where ret is used, it was guaranteed to be reassigned
beforehand.  But since the function returns -errno, and -1 is not
always the right errno, it's better to initialize to -EIO.

An upcoming patch wants to track two bitmaps in
do_sync_target_write(); this will be easier if the current variables
related to the dirty bitmap are renamed.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20250509204341.3553601-21-eblake@redhat.com>
block/mirror.c