]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix stalled lag columns in pg_stat_replication when replay LSN stops advancing.
authorFujii Masao <fujii@postgresql.org>
Wed, 22 Oct 2025 02:27:15 +0000 (11:27 +0900)
committerFujii Masao <fujii@postgresql.org>
Wed, 22 Oct 2025 02:27:15 +0000 (11:27 +0900)
commit883a95646a8e67a2d316f230712ed82b8ba58e28
treec9a3c1a390122be0f369e8c61f37877381ffdb87
parent2519fa836235d371a6d7f5c2eb3a8f379120a988
Fix stalled lag columns in pg_stat_replication when replay LSN stops advancing.

Previously, when the replay LSN reported in feedback messages from a standby
stopped advancing, for example, due to a recovery conflict, the write_lag and
flush_lag columns in pg_stat_replication would initially update but then stop
progressing. This prevented users from correctly monitoring replication lag.

The problem occurred because when any LSN stopped updating, the lag tracker's
cyclic buffer became full (the write head reached the slowest read head).
In that state, the lag tracker could no longer compute round-trip lag values
correctly.

This commit fixes the issue by handling the slowest read entry (the one
causing the buffer to fill) as a separate overflow entry and freeing space
so the write and other read heads can continue advancing in the buffer.
As a result, write_lag and flush_lag now continue updating even if the reported
replay LSN remains stalled.

Backpatch to all supported versions.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <lic@highgo.com>
Reviewed-by: Shinya Kato <shinya11.kato@gmail.com>
Reviewed-by: Xuneng Zhou <xunengzhou@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwGdGQ=1-X-71Caee-LREBUXSzyohkoQJd4yZZCMt24C0g@mail.gmail.com
Backpatch-through: 13
src/backend/replication/walsender.c