]> git.ipfire.org Git - thirdparty/coreutils.git/commit
tests: improve diagnostics when asserting empty files
authorPádraig Brady <P@draigBrady.com>
Tue, 6 May 2014 01:37:43 +0000 (02:37 +0100)
committerPádraig Brady <P@draigBrady.com>
Tue, 6 May 2014 23:06:00 +0000 (00:06 +0100)
commit8840a00cd79b8beae72b1a0ec6b9e64912633c13
tree32cba40c4c2d88a8cf75c7721742e367bd9a0398
parent0b04ff22edcd7b75f0929f5bede7d814d100e2f1
tests: improve diagnostics when asserting empty files

* tests/chmod/c-option.sh: Use `compare /dev/null ... || fail=1`
rather than `test -s ... && fail=1`, so that the file contents
are output, thus improving diagnostics for failing tests.
* tests/cp/acl.sh: Likewise.
* tests/cp/cp-a-selinux.sh: Likewise.
* tests/cp/cp-mv-enotsup-xattr.sh: Likewise.
* tests/cp/reflink-perm.sh: Likewise.
* tests/dd/misc.sh: Likewise.
* tests/misc/env-null.sh: Likewise.
* tests/misc/env.sh: Likewise.
* tests/misc/nice.sh: Likewise.
* tests/misc/nohup.sh: Likewise.
* tests/misc/printenv.sh: Likewise.
* tests/misc/xattr.sh: Likewise.
* tests/mv/update.sh: Likewise.
* tests/rm/deep-2.sh: Likewise.
* tests/rm/read-only.sh: Likewise.
* tests/split/r-chunk.sh: Likewise.
* tests/tail-2/follow-stdin.sh: Likewise.
* tests/tail-2/inotify-race.sh: Likewise.
* tests/tail-2/wait.sh: Likewise.
* tests/touch/no-dereference.sh: Likewise.

* cfg.mk (sc_prohibit_test_empty:): New syntax-check.
* tests/cp/proc-zero-len.sh: Adjust to avoid false syntax-check failure.
* tests/cp/proc-zero-len.sh: Likewise.
* tests/mv/part-symlink.sh: Likewise.
* tests/tail-2/infloop-1.sh: Likewise.
24 files changed:
cfg.mk
tests/chmod/c-option.sh
tests/cp/acl.sh
tests/cp/cp-a-selinux.sh
tests/cp/cp-mv-enotsup-xattr.sh
tests/cp/proc-zero-len.sh
tests/cp/reflink-perm.sh
tests/dd/misc.sh
tests/misc/env-null.sh
tests/misc/env.sh
tests/misc/nice.sh
tests/misc/nohup.sh
tests/misc/printenv.sh
tests/misc/xattr.sh
tests/mv/part-symlink.sh
tests/mv/update.sh
tests/rm/deep-2.sh
tests/rm/read-only.sh
tests/split/r-chunk.sh
tests/tail-2/follow-stdin.sh
tests/tail-2/infloop-1.sh
tests/tail-2/inotify-race.sh
tests/tail-2/wait.sh
tests/touch/no-dereference.sh