]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Remove & ban use of select() for waiting for I/O
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 13 May 2013 13:43:20 +0000 (14:43 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Mon, 13 May 2013 16:32:43 +0000 (17:32 +0100)
commit8845d8dfa340f3065d7ee1e6e51cfb1ec9028ee6
tree1831fa24b7d95c1ae0b366e08e52ffd66cabb9eb
parent8f76ad9992d02fded371649e0640c9d1d3b893c0
Remove & ban use of select() for waiting for I/O

Use of the select() system call is inherantly dangerous since
applications will hit a buffer overrun if any FD number exceeds
the size of the select set size (typically 1024). Replace the
two uses of select() with poll() and use cfg.mk to ban any
future use of select().

NB: This changes the phyp driver so that it uses an infinite
timeout, instead of busy-waiting for 1ms at a time.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
cfg.mk
src/phyp/phyp_driver.c
src/util/virnetlink.c