]> git.ipfire.org Git - thirdparty/openssl.git/commit
fips provider: explicitly setup cpuid when initializing
authorHongren Zheng <i@zenithal.me>
Thu, 16 May 2024 08:41:25 +0000 (16:41 +0800)
committerTomas Mraz <tomas@openssl.org>
Mon, 20 May 2024 08:16:02 +0000 (10:16 +0200)
commit88dec6e12d09d8b577e3d70dd124950b4c46dd2a
treeef3623c06a4ff7d1e5e68310e198258e4190af12
parent4129b171735f734d16d350f57a7c7e97191b393e
fips provider: explicitly setup cpuid when initializing

Fixes: #23979
Previously fips module relied on OPENSSL_cpuid_setup
being used as constructor by the linker to correctly
setup the capability vector, either via .section .init
(for x86_64) or via __attribute__((constructor)).

This would make ld.so call OPENSSL_cpuid_setup before
the init function for fips module. However, this early
constructing behavior has several disadvantages:

1. Not all platform/toolchain supports such behavior

2. Initialisation sequence is not well defined, and
some function might not be initialized when cpuid_setup
is called

3. Implicit path is hard to maintain and debug

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24419)

(cherry picked from commit a192b2439c0207ce1b04ba6137329b68f9e23680)
providers/fips/fipsprov.c