]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration: Skip only empty block devices
authorCédric Le Goater <clg@redhat.com>
Tue, 12 Mar 2024 12:04:31 +0000 (13:04 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 19 Mar 2024 16:22:46 +0000 (19:22 +0300)
commit8996768ebcd5bd5129fe9c10980e9e7ecafab7f2
tree04147cf544791cdd85c3bde526f7dcdd1654e7f9
parent7820b9b7a0b5ac594a142538ce7bf62dc7711420
migration: Skip only empty block devices

The block .save_setup() handler calls a helper routine
init_blk_migration() which builds a list of block devices to take into
account for migration. When one device is found to be empty (sectors
== 0), the loop exits and all the remaining devices are ignored. This
is a regression introduced when bdrv_iterate() was removed.

Change that by skipping only empty devices.

Cc: Markus Armbruster <armbru@redhat.com>
Cc: qemu-stable <qemu-stable@nongnu.org>
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Fixes: fea68bb6e9fa ("block: Eliminate bdrv_iterate(), use bdrv_next()")
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Link: https://lore.kernel.org/r/20240312120431.550054-1-clg@redhat.com
[peterx: fix "Suggested-by:"]
Signed-off-by: Peter Xu <peterx@redhat.com>
(cherry picked from commit 2e128776dc56f502c2ee41750afe83938f389528)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
migration/block.c