]> git.ipfire.org Git - thirdparty/qemu.git/commit
tests/unit: remove block layer code from test-nested-aio-poll
authorPaolo Bonzini <pbonzini@redhat.com>
Sun, 1 Sep 2024 23:59:42 +0000 (01:59 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 2 Oct 2024 10:58:46 +0000 (12:58 +0200)
commit89d26d34ce8bb95552570e729d3a7e8cb17f7369
tree37809986e7c11b2c31b5fad8ed8f19dff2fb8dd6
parentab891454ebe82f7e359be721007652556f9f8356
tests/unit: remove block layer code from test-nested-aio-poll

GCC is reporting a NULL pointer dereference when compiling aio_wait_kick()
with LTO.

The issue is that test-nested-aio-poll.c does not call qemu_init_main_loop().
It doesn't _need_ to because it never calls AIO_WAIT_WHILE(), but it seems
that LTO does not do enough dead-code elimination to catch that.

Fortunately aio_wait_kick() is only used in few places, and only in block
layer or system emulation code; and this test only needs the core event loop
functionality.  It does not even need iothreads.   So remove everything that
calls aio_wait_kick(), which is nice for coverage compared to adding the call
to qemu_init_main_loop().

Reported-by: Richard W.M. Jones <rjones@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2434
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
tests/unit/meson.build