]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gold: Properly remove the versioned symbol
authorH.J. Lu <hjl.tools@gmail.com>
Sat, 1 Jun 2024 04:30:34 +0000 (21:30 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Sun, 9 Jun 2024 06:54:39 +0000 (23:54 -0700)
commit89d801850ac03d0531f7eef3d6978bec17a30a2d
tree7c8719feee02ca0df80571a765d46ce05394bd71
parent2b05f934486de42f8200bf11cece21ae3bc284e6
gold: Properly remove the versioned symbol

When the versioned symbol foo is removed from the shared library,  the
".symver foo,foo@VER" directive provides binary compatibility for foo@VER.
In this case, the unversioned symbol foo should be hidden and shouldn't
generate a multiple definition error.

PR gold/31830
* resolve.cc (Symbol_table::resolve): Move symbol version handling
to ...
* symtab.cc (Symbol_table::add_from_object): Here. If the hidden
version from .symver is the same as the default version from the
unversioned symbol, don't make the unversioned symbol the default
versioned
symbol.
* testsuite/Makefile.am (check_SCRIPTS): Add ver_test_pr31830.sh.
(check_DATA): ver_test_pr31830_a.syms and ver_test_pr31830_b.syms.
(ver_test_pr31830_a.syms): New.
(ver_test_pr31830_b.syms): Likewise.
(ver_test_pr31830_a.so): Likewise.
(ver_test_pr31830_b.so): Likewise.
* testsuite/Makefile.in: Regenerated.
* testsuite/ver_test_pr31830.script: New file.
* testsuite/ver_test_pr31830.sh: Likewise.
* testsuite/ver_test_pr31830_a.c: Likewise.
* testsuite/ver_test_pr31830_b.c: Likewise.
* testsuite/ver_test_pr31830_lto.c: Likewise.
* testsuite/ver_test_pr31830_lto.sh: Likewise.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
gold/resolve.cc
gold/symtab.cc
gold/testsuite/Makefile.am
gold/testsuite/Makefile.in
gold/testsuite/ver_test_pr31830.script [new file with mode: 0644]
gold/testsuite/ver_test_pr31830.sh [new file with mode: 0755]
gold/testsuite/ver_test_pr31830_a.c [new file with mode: 0644]
gold/testsuite/ver_test_pr31830_b.c [new file with mode: 0644]
gold/testsuite/ver_test_pr31830_lto.c [new file with mode: 0644]
gold/testsuite/ver_test_pr31830_lto.sh [new file with mode: 0755]