]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Revert "wifi: ath9k: use devm for request_irq()"
authorToke Høiland-Jørgensen <toke@redhat.com>
Thu, 8 Aug 2024 10:37:57 +0000 (12:37 +0200)
committerKalle Valo <quic_kvalo@quicinc.com>
Sat, 10 Aug 2024 07:21:58 +0000 (10:21 +0300)
commit89fbe672bd0e5e5c39600fcc7a3bca0b8a212d23
tree7e98b52d1cf0ad039cfb656cecaacec1486933ff
parenta66de2d0f22b1740f3f9777776ad98c4bee62dff
Revert "wifi: ath9k: use devm for request_irq()"

This reverts commit 92da4ce847bc5d942ddfdb102dba92f4e2797a59.

Felix pointed out that moving to devm for request_irq() can lead to a use after
free, and that avoiding that means having explicit frees that makes the devm
thing pretty pointless. So let's just revert the patch.

Link: https://lore.kernel.org/r/201f06b6-14f5-41bb-8897-49665cf14b66@nbd.name
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20240808103758.11696-1-toke@toke.dk
drivers/net/wireless/ath/ath9k/ahb.c
drivers/net/wireless/ath/ath9k/pci.c