]> git.ipfire.org Git - thirdparty/linux.git/commit
idpf: fix potential memory leak on kcalloc() failure
authorMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Fri, 4 Apr 2025 10:54:21 +0000 (12:54 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 29 Apr 2025 21:28:24 +0000 (14:28 -0700)
commit8a558cbda51bef09773c72bf74a32047479110c7
tree8428e0b369afc7298e985a4485a807cac43bddf9
parentd4cb1ecc22908ef46f2885ee2978a4f22e90f365
idpf: fix potential memory leak on kcalloc() failure

In case of failing on rss_data->rss_key allocation the function is
freeing vport without freeing earlier allocated q_vector_idxs. Fix it.

Move from freeing in error branch to goto scheme.

Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
Reviewed-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Suggested-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Samuel Salin <Samuel.salin@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/idpf/idpf_lib.c