]> git.ipfire.org Git - thirdparty/qemu.git/commit
accel: remove dead statement and useless assertion
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 29 Oct 2024 09:43:16 +0000 (10:43 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 31 Oct 2024 17:28:32 +0000 (18:28 +0100)
commit8aade934dfa6ef9a1ca20666078e7c2d19e56368
treefdb6dfa276752181e57cf1c42c41272fb0627cbf
parent3139ad088b52ab840d760d40962fc0db57c62d83
accel: remove dead statement and useless assertion

ops is assigned again just below, and the result of the assignment must
be non-NULL.

Originally, the check for NULL was meant to be a check for the existence
of the ops class:

    ops = ACCEL_OPS_CLASS(object_class_by_name(ops_name));
    ...
    g_assert(ops != NULL);

(where the ops assignment begot the one that I am removing); but this is
meaningless now that oc is checked to be non-NULL before ops is assigned
(commit 5141e9a23fc, "accel: abort if we fail to load the accelerator
plugin", 2022-11-06).

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
accel/accel-system.c