]> git.ipfire.org Git - thirdparty/qemu.git/commit
qcow1: Validate L2 table size (CVE-2014-0222)
authorKevin Wolf <kwolf@redhat.com>
Thu, 15 May 2014 14:10:11 +0000 (16:10 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 3 Jul 2014 21:31:28 +0000 (16:31 -0500)
commit8b17eb6e6cdd4d5b4f3291c7e8afff83960f00d7
treeefc7176bfc75d40abc8aab7357a3dc6986a7b459
parente6c55cf7c25ceb0c14a292520a61786374f69bcf
qcow1: Validate L2 table size (CVE-2014-0222)

Too large L2 table sizes cause unbounded allocations. Images actually
created by qemu-img only have 512 byte or 4k L2 tables.

To keep things consistent with cluster sizes, allow ranges between 512
bytes and 64k (in fact, down to 1 entry = 8 bytes is technically
working, but L2 table sizes smaller than a cluster don't make a lot of
sense).

This also means that the number of bytes on the virtual disk that are
described by the same L2 table is limited to at most 8k * 64k or 2^29,
preventively avoiding any integer overflows.

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
(cherry picked from commit 42eb58179b3b215bb507da3262b682b8a2ec10b5)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/qcow.c
tests/qemu-iotests/092
tests/qemu-iotests/092.out