]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/arm/translate.c: Delete/amend incorrect comments
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 3 Aug 2020 13:28:15 +0000 (14:28 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 24 Aug 2020 09:15:11 +0000 (10:15 +0100)
commit8b4c9a50dc9531a729ae4b5941d287ad0422db48
tree41979a56ab5cd289b97744b1babe1b88cefe1399
parente60527c5d501e5015a119a0388a27abeae4dac09
target/arm/translate.c: Delete/amend incorrect comments

In arm_tr_init_disas_context() we have a FIXME comment that suggests
"cpu_M0 can probably be the same as cpu_V0".  This isn't in fact
possible: cpu_V0 is used as a temporary inside gen_iwmmxt_shift(),
and that function is called in various places where cpu_M0 contains a
live value (i.e.  between gen_op_iwmmxt_movq_M0_wRn() and
gen_op_iwmmxt_movq_wRn_M0() calls).  Remove the comment.

We also have a comment on the declarations of cpu_V0/V1/M0 which
claims they're "for efficiency".  This isn't true with modern TCG, so
replace this comment with one which notes that they're only used with
the iwmmxt decode.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20200803132815.3861-1-peter.maydell@linaro.org
target/arm/translate.c