]> git.ipfire.org Git - thirdparty/linux.git/commit
net_sched: sch_sfq: use a temporary work area for validating configuration
authorOctavian Purdila <tavip@google.com>
Mon, 7 Apr 2025 20:24:07 +0000 (13:24 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Apr 2025 11:55:48 +0000 (12:55 +0100)
commit8c0cea59d40cf6dd13c2950437631dd614fbade6
treef1b8fc23b3bf3e15ba217bd62d9c6b3689492fb1
parent7f1ff1b38a7c8b872382b796023419d87d78c47e
net_sched: sch_sfq: use a temporary work area for validating configuration

Many configuration parameters have influence on others (e.g. divisor
-> flows -> limit, depth -> limit) and so it is difficult to correctly
do all of the validation before applying the configuration. And if a
validation error is detected late it is difficult to roll back a
partially applied configuration.

To avoid these issues use a temporary work area to update and validate
the configuration and only then apply the configuration to the
internal state.

Signed-off-by: Octavian Purdila <tavip@google.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_sfq.c