]> git.ipfire.org Git - thirdparty/linux.git/commit
wifi: mac80211: remove DEAUTH_NEED_MGD_TX_PREP
authorJohannes Berg <johannes.berg@intel.com>
Thu, 27 Jun 2024 11:25:27 +0000 (13:25 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 28 Jun 2024 07:56:30 +0000 (09:56 +0200)
commit8c62617295d3c4cd03f1a02c3b9bf9d4e6d6e0c6
tree0deda041d85b5a0e2636afca1eb5eaa62a030ca4
parent4314bb46cb56851f13bda9db356ebc3cf750b7f1
wifi: mac80211: remove DEAUTH_NEED_MGD_TX_PREP

This flag is annoying because it puts a lot of logic into mac80211
that could just as well be in the driver (only iwlmvm uses it) and
the implementation is also broken for MLO.

Remove the flag in favour of calling drv_mgd_prepare_tx() without
any conditions even for the deauth-while-assoc case. The drivers
that implement it can take the appropriate actions, which for the
only user of DEAUTH_NEED_MGD_TX_PREP (iwlmvm) is a bit more tricky
than the implementation in mac80211 is anyway, and all others have
no need and can just exit if info->was_assoc is set.

Reviewed-by: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20240627132527.94924bcc9c9e.I328a219e45f2e2724cd52e75bb9feee3bf21a463@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
include/net/mac80211.h
net/mac80211/debugfs.c
net/mac80211/main.c
net/mac80211/mlme.c