]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Use the correct PG_DETOAST_DATUM macro in BRIN
authorTomas Vondra <tomas.vondra@postgresql.org>
Sun, 14 Apr 2024 16:19:52 +0000 (18:19 +0200)
committerTomas Vondra <tomas.vondra@postgresql.org>
Sun, 14 Apr 2024 16:24:38 +0000 (18:24 +0200)
commit8cea358b128fea93c8360c9521dcf954775a38ca
tree48eaf29c02f43cba6b1ef25c99cdee8aab017f3e
parentccd8f0fa1e541e6b59ac2727509cafa6367e5886
Use the correct PG_DETOAST_DATUM macro in BRIN

Commit 6bcda4a721 replaced PG_DETOAST_DATUM with PG_DETOAST_DATUM_PACKED
in two BRIN output functions, for minmax-multi and bloom opclasses. But
this is incorrect - the code is accessing the data through structs that
already include a 4B header, so the detoast needs to match that. But the
PACKED macro may keep the 1B header, which means the struct fields will
point to incorrect data.

Backpatch-through: 16
Discussion: https://postgr.es/m/1df00a66-db5a-4e66-809a-99b386a06d86%40enterprisedb.com
src/backend/access/brin/brin_bloom.c
src/backend/access/brin/brin_minmax_multi.c