]> git.ipfire.org Git - thirdparty/qemu.git/commit
virtio: kconfig: memory devices are PCI only
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 6 Sep 2024 10:16:58 +0000 (12:16 +0200)
committerDavid Hildenbrand <david@redhat.com>
Tue, 24 Sep 2024 09:33:34 +0000 (11:33 +0200)
commit8d018fe59a0beff580ac6b3399d642c4277d9dd0
tree052cfe6cce84c918c3e75a3cbbf688ffdc951a6f
parent01dc65a3bc262ab1bec8fe89775e9bbfa627becb
virtio: kconfig: memory devices are PCI only

Virtio memory devices rely on PCI BARs to expose the contents of memory.
Because of this they cannot be used (yet) with virtio-mmio or virtio-ccw.
In fact the code that is common to virtio-mem and virtio-pmem, which
is in hw/virtio/virtio-md-pci.c, is only included if CONFIG_VIRTIO_PCI
is set.  Reproduce the same condition in the Kconfig file, only allowing
VIRTIO_MEM and VIRTIO_PMEM to be defined if the transport supports it.

Without this patch it is possible to create a configuration with
CONFIG_VIRTIO_PCI=n and CONFIG_VIRTIO_MEM=y, but that causes a
linking failure.

Message-ID: <20240906101658.514470-1-pbonzini@redhat.com>
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
hw/virtio/Kconfig