]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iwlwifi: dbg: fix debug monitor stop and restart delays
authorShahar S Matityahu <shahar.s.matityahu@intel.com>
Thu, 16 May 2019 07:31:17 +0000 (10:31 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Jul 2019 07:12:47 +0000 (09:12 +0200)
commit8d4c01b36e0ac45bf6a03443027d0752abef8339
tree1a44b1c55a6c0a92362fd00f5cbe2ff765c40197
parent7bc8dfa08807e0ab31fb870e4ed0d3355b7acdca
iwlwifi: dbg: fix debug monitor stop and restart delays

[ Upstream commit fc838c775f35e272e5cc7ef43853f0b55babbe37 ]

The driver should delay only in recording stop flow between writing to
DBGC_IN_SAMPLE register and DBGC_OUT_CTRL register. Any other delay is
not needed.

Change the following:
1. Remove any unnecessary delays in the flow
2. Increase the delay in the stop recording flow since 100 micro is
   not enough
3. Use usleep_range instead of delay since the driver is allowed to
   sleep in this flow.

Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Fixes: 5cfe79c8d92a ("iwlwifi: fw: stop and start debugging using host command")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/intel/iwlwifi/fw/dbg.c
drivers/net/wireless/intel/iwlwifi/fw/dbg.h