]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Remove unneeded check for extra_certs_file_inline
authorSteffan Karger <steffan@karger.me>
Tue, 8 Nov 2016 21:28:27 +0000 (22:28 +0100)
committerDavid Sommerseth <davids@openvpn.net>
Wed, 16 Nov 2016 10:39:38 +0000 (11:39 +0100)
commit8d5b06e6fc46e214e1498352603a95028aa5c113
treea0541bb20cf822e9087dce6ca75473519ca8353e
parent160504a2955c4478cd2c0323452929e07016a336
Remove unneeded check for extra_certs_file_inline

As with all the file/file_inline variable, the _inline variable is only
relevant if the file variable is equal to INLINE_FILE_TAG.  The
tls_ctx_load_extra_certs() function nicely follows this mantra.

Removing this unneeded check silences a coverity 'dereference after null
check' warning (tls_ctx_load_extra_certs() always dereferences
options->extra_cert_file, and the check implies it might be null).  In
reality, this cannot occur, because if options->extra_cert_file_inline is
non-null, so is options->extra_cert_file.  Still, coverity is correct this
this check is a bit weird, so let's fix it and make coverity happy.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: David Sommerseth <davids@openvpn.net>
Message-Id: <1478640507-14415-1-git-send-email-steffan@karger.me>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg12978.html
Signed-off-by: David Sommerseth <davids@openvpn.net>
src/openvpn/ssl.c