]> git.ipfire.org Git - thirdparty/linux.git/commit
hwrng: Fix unsigned comparison with less than zero
authorYueHaibing <yuehaibing@huawei.com>
Tue, 19 Feb 2019 06:33:02 +0000 (14:33 +0800)
committerArnd Bergmann <arnd@arndb.de>
Wed, 20 Feb 2019 16:56:27 +0000 (17:56 +0100)
commit8deed847445a8fb619689988a24c0f8df1369a58
tree6f7c2859b0363e3a0a6827bac2657a9c8dda8227
parentbb342f016862a0d5b013c2a9dce0f91412b0be77
hwrng: Fix unsigned comparison with less than zero

The return from the call to tee_client_invoke_func can be a
negative error code however this is being assigned to an
unsigned variable 'ret' hence the check is always false.
Fix this by making 'ret' an int.

Detected by Coccinelle ("Unsigned expression compared with zero:
ret < 0")

Fixes: 5fe8b1cc6a03 ("hwrng: add OP-TEE based rng driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/char/hw_random/optee-rng.c