]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sched/fair: Cleanup pick_task_fair() vs throttle
authorPeter Zijlstra <peterz@infradead.org>
Wed, 3 Apr 2024 07:50:07 +0000 (09:50 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Sat, 17 Aug 2024 09:06:40 +0000 (11:06 +0200)
commit8e2e13ac6122915bd98315237b0317495e391be0
treeefaee6b8fb17588e694f857e3ab17217ac9ad640
parent949090eaf0a3e39aa0f4a675407e16d0e975da11
sched/fair: Cleanup pick_task_fair() vs throttle

Per 54d27365cae8 ("sched/fair: Prevent throttling in early
pick_next_task_fair()") the reason check_cfs_rq_runtime() is under the
'if (curr)' check is to ensure the (downward) traversal does not
result in an empty cfs_rq.

But then the pick_task_fair() 'copy' of all this made it restart the
traversal anyway, so that seems to solve the issue too.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Ben Segall <bsegall@google.com>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Tested-by: Valentin Schneider <vschneid@redhat.com>
Link: https://lkml.kernel.org/r/20240727105028.501679876@infradead.org
kernel/sched/fair.c