]> git.ipfire.org Git - thirdparty/hostap.git/commit
dbus_new_handlers: Omit errant dbus_message_unref
authorPaul Stewart <pstew@google.com>
Sat, 4 Dec 2010 19:58:44 +0000 (11:58 -0800)
committerJouni Malinen <j@w1.fi>
Sat, 4 Dec 2010 19:58:44 +0000 (11:58 -0800)
commit8e5f078fb959436f944ae9a5558c07ae6eec2e6e
treefb05b4cee2d26b3b2412836c913616d304599852
parentc4d7fc90a2629500f370ccef553fd848c3c95c64
dbus_new_handlers: Omit errant dbus_message_unref

This unref is guaranteed to be freeing a NULL pointer.

Tested manually: use dbus-send to send an invalid debug level parameter

Before change:

$ dbus-send --system --dest=fi.w1.wpa_supplicant1 --print-reply
/fi/w1/wpa_supplicant1 org.freedesktop.DBus.Properties.Set
string:fi.w1.wpa_supplicant1 string:DebugLevel variant:string:msgdumpf
Error org.freedesktop.DBus.Error.NoReply: Message did not receive a reply
(timeout by message bus)
(and then wpa_supplicant crashes)

After change:

$ dbus-send --system --dest=fi.w1.wpa_supplicant1 --print-reply
/fi/w1/wpa_supplicant1 org.freedesktop.DBus.Properties.Set
string:fi.w1.wpa_supplicant1 string:DebugLevel variant:string:msgdumpf
Error fi.w1.wpa_supplicant1.InvalidArgs: Did not receive correct message
arguments.

Signed-off-by: Paul Stewart <pstew@google.com>
wpa_supplicant/dbus/dbus_new_handlers.c